extracting to/cc addresses for stg mail

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

extracting to/cc addresses for stg mail

Bjorn Helgaas
I'm new to stg, so maybe I'm missing the easy way to do this.
That said, I'd like to maintain "To:" fields in the patch
description, like this:

  Signed-off-by: Bjorn Helgaas <[hidden email]>
  To: Andi Kleen <[hidden email]>
  Cc: Andrew Morton <[hidden email]>

"stg mail --auto" takes care of adding Andrew to the Cc list,
but I have to manually deal with Andi.

I've been doing that by using "stg mail --auto -E" and manually
moving the To: line to the top, but that's a hassle.  I don't
really want to use "stg mail --to=", because then I have to dig
out the To: line contents first.  I don't really want to use
different template files, because I often have one-off self-
contained patches that go different places.

Is there a way to make stg pay attention to my "To:" lines in
the patch description?  Or another way to accomplish this?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: extracting to/cc addresses for stg mail

Karl Wiberg-2
On 2008-08-01 16:50:45 -0600, Bjorn Helgaas wrote:

> Is there a way to make stg pay attention to my "To:" lines in the
> patch description? Or another way to accomplish this?

It can't do it at the moment, but it should be easy to fix. In
stgit/commands/mail.py, the following lines

    if options.auto:
        extra_cc = __get_signers_list(descr)
    else:
        extra_cc = []

add the extra CC addresses. You could augment __get_signers_list to
return a tuple of to and cc addresses instead of just cc addresses,
pass those addesses to the same place extra_cc is fed now, and that's
it.

If you really hate Python, don't have time, etc., I can do it for you
(as long as you agree to test it) -- just ask -- but I try to take
every opportunity to get people to contribute patches. :-)

--
Karl Hasselström, [hidden email]
      www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: extracting to/cc addresses for stg mail

Bjorn Helgaas
On Tuesday 05 August 2008 07:39:22 am Karl Hasselström wrote:

> On 2008-08-01 16:50:45 -0600, Bjorn Helgaas wrote:
>
> > Is there a way to make stg pay attention to my "To:" lines in the
> > patch description? Or another way to accomplish this?
>
> It can't do it at the moment, but it should be easy to fix. In
> stgit/commands/mail.py, the following lines
>
>     if options.auto:
>         extra_cc = __get_signers_list(descr)
>     else:
>         extra_cc = []
>
> add the extra CC addresses. You could augment __get_signers_list to
> return a tuple of to and cc addresses instead of just cc addresses,
> pass those addesses to the same place extra_cc is fed now, and that's
> it.
>
> If you really hate Python, don't have time, etc., I can do it for you
> (as long as you agree to test it) -- just ask -- but I try to take
> every opportunity to get people to contribute patches. :-)

Thanks for the hints.  I'll take a look at it.  It'll take me a while,
but it's a good excuse to try to learn a little Python.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html