[StGIT PATCH] Do not insert an empty line before the diffstat info

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[StGIT PATCH] Do not insert an empty line before the diffstat info

Samuel Tardieu
To make the format of stg output closer to the plain git one, do
not insert an empty line between the "---" separator and the
diffstat information.

Signed-off-by: Samuel Tardieu <[hidden email]>
---
 templates/mailattch.tmpl   |    1 -
 templates/patchexport.tmpl |    1 -
 templates/patchmail.tmpl   |    1 -
 3 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/templates/mailattch.tmpl b/templates/mailattch.tmpl
index 430b341..70d2df0 100644
--- a/templates/mailattch.tmpl
+++ b/templates/mailattch.tmpl
@@ -11,7 +11,6 @@ Content-Disposition: inline
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 --MIMEBOUNDARY
 Content-Type: text/plain; name=%(patch)s.patch
diff --git a/templates/patchexport.tmpl b/templates/patchexport.tmpl
index e7f3481..11f2075 100644
--- a/templates/patchexport.tmpl
+++ b/templates/patchexport.tmpl
@@ -4,6 +4,5 @@ From: %(authname)s <%(authemail)s>
 
 %(longdescr)s
 ---
-
 %(diffstat)s
 
diff --git a/templates/patchmail.tmpl b/templates/patchmail.tmpl
index f5c35c2..7d4022a 100644
--- a/templates/patchmail.tmpl
+++ b/templates/patchmail.tmpl
@@ -3,6 +3,5 @@ Subject: [%(prefix)sPATCH%(version)s%(number)s] %(shortdescr)s
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 %(diff)s

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [StGIT PATCH] Do not insert an empty line before the diffstat info

Karl Wiberg-2
On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:

> To make the format of stg output closer to the plain git one, do not
> insert an empty line between the "---" separator and the diffstat
> information.

Thanks, will apply. (IMO it's slightly uglier, but it's better to be
consistent. And it does save some space.)

--
Karl Hasselström, [hidden email]
      www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [StGIT PATCH] Do not insert an empty line before the diffstat info

Catalin Marinas
2008/8/4 Karl Hasselström <[hidden email]>:
> On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:
>
>> To make the format of stg output closer to the plain git one, do not
>> insert an empty line between the "---" separator and the diffstat
>> information.
>
> Thanks, will apply. (IMO it's slightly uglier, but it's better to be
> consistent. And it does save some space.)

Without this change, I could easily spot people posting patches with
StGIT rather than Git :-). Anyway, I'm OK with this patch as well.
Thanks.

--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html