Re: [PATCH 0/2] gitweb use sections

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/2] gitweb use sections

Gustavo Sverzut Barbieri
Since nobody replied and I missed some gitweb guys in CC, I'm adding
Petr and Jakub, as some guys said on IRC.

Have anyone tried this patch, any problems?


On Mon, Jul 28, 2008 at 11:34 PM, Gustavo Sverzut Barbieri
<[hidden email]> wrote:

> The following two patches will add sections to gitweb so usability is
> improved for large project listing. It looks like:
>
>    http://staff.get-e.org/
>
> but it's a new code that also supports owner sort.
>
> Patches orverview:
>
>  * [PATCH 1/2] gitweb: sort projects by path.
>   This one is required to fix project sort. Since we use paths, we
>   should compare individual components to make it look like a
>   tree. Since we now can enable sections this error will be more
>   evident, so there is the fix.
>
>  * [PATCH 2/2] gitweb: add section support to gitweb project listing.
>   The real section work. This will add use_sections variable and if
>   it evaluates to true sections will be enabled. Just project and
>   owner sections are implemented.
>
> I hope it looks good for inclusion. Last time I did perl was about 8
> years ago, please point any problems and I'll fix them.
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: [hidden email]
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
>



--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [hidden email]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/2] gitweb use sections

Petr Baudis
  Hi,

On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
> Since nobody replied and I missed some gitweb guys in CC, I'm adding
> Petr and Jakub, as some guys said on IRC.
>
> Have anyone tried this patch, any problems?

  sorry, I have it in my review queue. At first pass it was looking
good, but I wanted to look at it better before commenting.

  One thing I'm wondering about is how to make this stuff configurable,
since I'm not very comfortable with adding more "unbound" configuration
variables and would rather prefer stuff to be added to the $features
array... I'm not at all sure about my own sentiment here, however.

--
                                Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name.  -- Ken Thompson and Dennis M. Ritchie
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/2] gitweb use sections

Gustavo Sverzut Barbieri
On Thu, Jul 31, 2008 at 5:32 PM, Petr Baudis <[hidden email]> wrote:

>  Hi,
>
> On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
>> Since nobody replied and I missed some gitweb guys in CC, I'm adding
>> Petr and Jakub, as some guys said on IRC.
>>
>> Have anyone tried this patch, any problems?
>
>  sorry, I have it in my review queue. At first pass it was looking
> good, but I wanted to look at it better before commenting.

no problem, just to see it was noticed or not :-)


>  One thing I'm wondering about is how to make this stuff configurable,
> since I'm not very comfortable with adding more "unbound" configuration
> variables and would rather prefer stuff to be added to the $features
> array... I'm not at all sure about my own sentiment here, however.

Path comparison (first patch), Sections (second), both?

I know path comparison can be a performance hit on large listings on
sites with heavy traffic. However, I don't see many people accessing
the projects page at the same time for long periods, it's not like
slashdot... people mostly use it to know about repositories and then
use git to track it.
    The slowness is due O(n^2) worst case of sort and each step is not
a bit heavier since it need to split path into components and walk
these. Maybe cache the split?

--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [hidden email]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 0/2] gitweb use sections

Gustavo Sverzut Barbieri
Yet another "ping" on this topic, news?

On Thu, Jul 31, 2008 at 5:58 PM, Gustavo Sverzut Barbieri
<[hidden email]> wrote:

> On Thu, Jul 31, 2008 at 5:32 PM, Petr Baudis <[hidden email]> wrote:
>>  Hi,
>>
>> On Thu, Jul 31, 2008 at 04:43:35PM -0300, Gustavo Sverzut Barbieri wrote:
>>> Since nobody replied and I missed some gitweb guys in CC, I'm adding
>>> Petr and Jakub, as some guys said on IRC.
>>>
>>> Have anyone tried this patch, any problems?
>>
>>  sorry, I have it in my review queue. At first pass it was looking
>> good, but I wanted to look at it better before commenting.
>
> no problem, just to see it was noticed or not :-)
>
>
>>  One thing I'm wondering about is how to make this stuff configurable,
>> since I'm not very comfortable with adding more "unbound" configuration
>> variables and would rather prefer stuff to be added to the $features
>> array... I'm not at all sure about my own sentiment here, however.
>
> Path comparison (first patch), Sections (second), both?
>
> I know path comparison can be a performance hit on large listings on
> sites with heavy traffic. However, I don't see many people accessing
> the projects page at the same time for long periods, it's not like
> slashdot... people mostly use it to know about repositories and then
> use git to track it.
>    The slowness is due O(n^2) worst case of sort and each step is not
> a bit heavier since it need to split path into components and walk
> these. Maybe cache the split?
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: [hidden email]
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>



--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [hidden email]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html