RPM spec file broken by README.md

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RPM spec file broken by README.md

Ron Isaacson
Hi everyone,

I've noticed that "make rpm" is failing for 2.8.0 because README was
replaced with README.md. This line in git.spec is the culprit:

%doc README COPYING Documentation/*.txt

Would it be possible to change this to README.md to match the source
tree? The rpm packages build just fine with that change. Thank you
very much!

  - Ron
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

[PATCH] git.spec: use README.md, not README

Matthieu Moy
The file was renamed in 4ad21f5 (README: use markdown syntax,
2016-02-25), but that commit forgot to update git.spec.in.

Reported-by: Ron Isaacson <[hidden email]>
Signed-off-by: Matthieu Moy <[hidden email]>
---
 git.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git.spec.in b/git.spec.in
index d61d537..bfd1cfb 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -146,7 +146,7 @@ rm -rf $RPM_BUILD_ROOT
 %files -f bin-man-doc-files
 %defattr(-,root,root)
 %{_datadir}/git-core/
-%doc README COPYING Documentation/*.txt
+%doc README.md COPYING Documentation/*.txt
 %{!?_without_docs: %doc Documentation/*.html Documentation/howto}
 %{!?_without_docs: %doc Documentation/technical}
 %{_sysconfdir}/bash_completion.d
--
2.7.2.334.g35ed2ae.dirty

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: RPM spec file broken by README.md

Christian Couder-2
In reply to this post by Ron Isaacson
Hi!

On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <[hidden email]> wrote:

> Hi everyone,
>
> I've noticed that "make rpm" is failing for 2.8.0 because README was
> replaced with README.md. This line in git.spec is the culprit:
>
> %doc README COPYING Documentation/*.txt
>
> Would it be possible to change this to README.md to match the source
> tree? The rpm packages build just fine with that change. Thank you
> very much!

Thanks for this bug report.

Would you care to send a patch?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: RPM spec file broken by README.md

Christian Couder-2
On Fri, Apr 1, 2016 at 1:23 PM, Christian Couder
<[hidden email]> wrote:

> Hi!
>
> On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <[hidden email]> wrote:
>> Hi everyone,
>>
>> I've noticed that "make rpm" is failing for 2.8.0 because README was
>> replaced with README.md. This line in git.spec is the culprit:
>>
>> %doc README COPYING Documentation/*.txt
>>
>> Would it be possible to change this to README.md to match the source
>> tree? The rpm packages build just fine with that change. Thank you
>> very much!
>
> Thanks for this bug report.
>
> Would you care to send a patch?

Ooops, it looks like Matthieu already sent a patch. Sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html