[RFC/PATCH] git.spec: fix changelog dates

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[RFC/PATCH] git.spec: fix changelog dates

MichaelJGruber
A few changelog entries have inconsistent dates, which rpmlint reports
as errors.

Fix them based on these assumptions:
- It's easier to mistype a number than a weekday abbreviation.
- changelog date must be before git commit date
- The mistyped date is just a few days off.

Signed-off-by: Michael J Gruber <[hidden email]>
---
I dunno if this is worthwhile, but rpmlint is the first thing we tell
packagers and reviewers to check.

 git.spec.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/git.spec.in b/git.spec.in
index bfd1cfb..eb581a3 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
 * Sat Jan 30 2010 Junio C Hamano <[hidden email]>
 - We don't ship Python bits until a real foreign scm interface comes.
 
-* Mon Feb 04 2009 David J. Mellor <[hidden email]>
+* Mon Feb 02 2009 David J. Mellor <[hidden email]>
 - fixed broken git help -w after renaming the git-core package to git.
 
 * Fri Sep 12 2008 Quy Tonthat <[hidden email]>
@@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Jun 21 2007 Shawn O. Pearce <[hidden email]>
 - Added documentation files for git-gui
 
-* Tue May 13 2007 Quy Tonthat <[hidden email]>
+* Sun May 13 2007 Quy Tonthat <[hidden email]>
 - Added lib files for git-gui
 - Added Documentation/technical (As needed by Git Users Manual)
 
@@ -272,7 +272,7 @@ rm -rf $RPM_BUILD_ROOT
 * Tue Mar 27 2007 Eygene Ryabinkin <[hidden email]>
 - Added the git-p4 package: Perforce import stuff.
 
-* Mon Feb 13 2007 Nicolas Pitre <[hidden email]>
+* Mon Feb 12 2007 Nicolas Pitre <[hidden email]>
 - Update core package description (Git isn't as stupid as it used to be)
 
 * Mon Feb 12 2007 Junio C Hamano <[hidden email]>
@@ -326,5 +326,5 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Jul 14 2005 Eric Biederman <[hidden email]>
 - Add the man pages, and the --without docs build option
 
-* Wed Jul 7 2005 Chris Wright <[hidden email]>
+* Wed Jul 6 2005 Chris Wright <[hidden email]>
 - initial git spec file
--
2.8.1.120.g4a400c2

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [RFC/PATCH] git.spec: fix changelog dates

Remi Galan Alfonso
Michael J Gruber <[hidden email]> wrote:

> A few changelog entries have inconsistent dates, which rpmlint reports
> as errors.
>
> Fix them based on these assumptions:
> - It's easier to mistype a number than a weekday abbreviation.
> - changelog date must be before git commit date
> - The mistyped date is just a few days off.
>
> Signed-off-by: Michael J Gruber <[hidden email]>
> ---
> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> packagers and reviewers to check.
>
>  git.spec.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/git.spec.in b/git.spec.in
> index bfd1cfb..eb581a3 100644
> --- a/git.spec.in
> +++ b/git.spec.in
> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Sat Jan 30 2010 Junio C Hamano <[hidden email]>
>  - We don't ship Python bits until a real foreign scm interface comes.
>  
> -* Mon Feb 04 2009 David J. Mellor <[hidden email]>
> +* Mon Feb 02 2009 David J. Mellor <[hidden email]>
>  - fixed broken git help -w after renaming the git-core package to git.
>  
>  * Fri Sep 12 2008 Quy Tonthat <[hidden email]>
> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
>  * Thu Jun 21 2007 Shawn O. Pearce <[hidden email]>
>  - Added documentation files for git-gui
>  
> -* Tue May 13 2007 Quy Tonthat <[hidden email]>
> +* Sun May 13 2007 Quy Tonthat <[hidden email]>

It is inconsistent with what you said in the commit message ("It's
easier to mistype a number than a weekday abbreviation.").

Following that logic, it should be:
        * Tue May 15 2007 Quy Tonthat <[hidden email]>

(or 08, I didn't check the condition "changelog date must be before
git commit date")

Thanks,
Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [RFC/PATCH] git.spec: fix changelog dates

MichaelJGruber
Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:

> Michael J Gruber <[hidden email]> wrote:
>> A few changelog entries have inconsistent dates, which rpmlint reports
>> as errors.
>>
>> Fix them based on these assumptions:
>> - It's easier to mistype a number than a weekday abbreviation.
>> - changelog date must be before git commit date
>> - The mistyped date is just a few days off.
>>
>> Signed-off-by: Michael J Gruber <[hidden email]>
>> ---
>> I dunno if this is worthwhile, but rpmlint is the first thing we tell
>> packagers and reviewers to check.
>>
>>  git.spec.in | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/git.spec.in b/git.spec.in
>> index bfd1cfb..eb581a3 100644
>> --- a/git.spec.in
>> +++ b/git.spec.in
>> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
>>  * Sat Jan 30 2010 Junio C Hamano <[hidden email]>
>>  - We don't ship Python bits until a real foreign scm interface comes.
>>  
>> -* Mon Feb 04 2009 David J. Mellor <[hidden email]>
>> +* Mon Feb 02 2009 David J. Mellor <[hidden email]>
>>  - fixed broken git help -w after renaming the git-core package to git.
>>  
>>  * Fri Sep 12 2008 Quy Tonthat <[hidden email]>
>> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
>>  * Thu Jun 21 2007 Shawn O. Pearce <[hidden email]>
>>  - Added documentation files for git-gui
>>  
>> -* Tue May 13 2007 Quy Tonthat <[hidden email]>
>> +* Sun May 13 2007 Quy Tonthat <[hidden email]>
>
> It is inconsistent with what you said in the commit message ("It's
> easier to mistype a number than a weekday abbreviation.").
>
> Following that logic, it should be:
> * Tue May 15 2007 Quy Tonthat <[hidden email]>
>
> (or 08, I didn't check the condition "changelog date must be before
> git commit date")

I did.

The thing is that you can't always fulfill all of these 3 conditions.
"Easier" doesn't mean that the other case is impossible, just less likely.

> Thanks,
> Rémi
>

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [RFC/PATCH] git.spec: fix changelog dates

Remi Galan Alfonso
Michael J Gruber <[hidden email]> wrote:

> Remi Galan Alfonso venit, vidit, dixit 05.04.2016 14:28:
> > Michael J Gruber <[hidden email]> wrote:
> >> A few changelog entries have inconsistent dates, which rpmlint reports
> >> as errors.
> >>
> >> Fix them based on these assumptions:
> >> - It's easier to mistype a number than a weekday abbreviation.
> >> - changelog date must be before git commit date
> >> - The mistyped date is just a few days off.
> >>
> >> Signed-off-by: Michael J Gruber <[hidden email]>
> >> ---
> >> I dunno if this is worthwhile, but rpmlint is the first thing we tell
> >> packagers and reviewers to check.
> >>
> >>  git.spec.in | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/git.spec.in b/git.spec.in
> >> index bfd1cfb..eb581a3 100644
> >> --- a/git.spec.in
> >> +++ b/git.spec.in
> >> @@ -229,7 +229,7 @@ rm -rf $RPM_BUILD_ROOT
> >>  * Sat Jan 30 2010 Junio C Hamano <[hidden email]>
> >>  - We don't ship Python bits until a real foreign scm interface comes.
> >>  
> >> -* Mon Feb 04 2009 David J. Mellor <[hidden email]>
> >> +* Mon Feb 02 2009 David J. Mellor <[hidden email]>
> >>  - fixed broken git help -w after renaming the git-core package to git.
> >>  
> >>  * Fri Sep 12 2008 Quy Tonthat <[hidden email]>
> >> @@ -262,7 +262,7 @@ rm -rf $RPM_BUILD_ROOT
> >>  * Thu Jun 21 2007 Shawn O. Pearce <[hidden email]>
> >>  - Added documentation files for git-gui
> >>  
> >> -* Tue May 13 2007 Quy Tonthat <[hidden email]>
> >> +* Sun May 13 2007 Quy Tonthat <[hidden email]>
> >
> > It is inconsistent with what you said in the commit message ("It's
> > easier to mistype a number than a weekday abbreviation.").
> >
> > Following that logic, it should be:
> >         * Tue May 15 2007 Quy Tonthat <[hidden email]>
> >
> > (or 08, I didn't check the condition "changelog date must be before
> > git commit date")
>
> I did.
>
> The thing is that you can't always fulfill all of these 3 conditions.
> "Easier" doesn't mean that the other case is impossible, just less likely.

Ah alright. Makes sense then, it is much harder to mistype 13 from 08
than from 15.

Sorry for the noise.

Thanks,
Rémi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html