[PATCH v7 0/2] Implement the GIT_TRACE_CURL environment variable
This is the seventh version but in reality is the complete rewriting of the patches discussed here
(here called V1)
*Changes from V6
- updated with junio suggestions ($gmane/295207)
* http.c: add redact_sensitive_header() helper
* http.c: renamed header_list and ptr_list to
headers and header
* http.c: reduce width in curl_dump_data
* http.c: curl_dump_data. cut strbuf_addch at a sensible place
* http.c: drop the nopriv_header variable: add an enum instead
*Changes from V5
- don't export curl_trace anymore. Define it static
- fix a minor cleanup (style) in setup_curl_trace
- and, finally, i rewrote completely curl_dump, separating it
into two functions (one for http header and one for the http data),
hoping for a coherent implementation with curl --ascii-trace output
but easier to read than the previous implementation that
used a hard-to-read double-loop.
*Changes from V4
- add a better abstraction with the routine setup_curl_trace
- curl_dump : drop the noex parameter, define nopriv boolean as int
- use decimal constant where appropiate
- fix multi-line comment
- redo the authorization header skip with a replace of possible sensitive data.
We prefer to print only:
09:00:53.238330 http.c:534 => Send header: Authorization: <redacted>
09:00:53.238330 http.c:534 => Send header: Authorization: Basic(o other scheme) <redacted>
as it was done in the original proposed suggestion by Jeff King.
This is because i think it's better not to print even the authorization scheme.
We add also the (previously missing) proxy-authorization case
- curl_dump: fix strbuf memory leak
as suggested by Jeff King
In this series i keep the original curl_dump parsing code, even though it is
objectively difficult to read. This is because the same code is used internally by curl
to do "ascii-trace" and is also reported in the libcurl code examples and test.
I think this may make maintenance of code easier in the future (libcurl
new dev, new features and so on)
Of course if the maintainer (or other) believes it is really necessary
to rewrite the above code to accept the patches i will do.
*Changes from V3
- add missing static to curl_dump
- reorder the patch order
- tried to fix all (but i am not sure) the problems reported by Julio ($gmane/292055)
- * squash the documentation with the http.c commit.
* in the trace prefix each line to indicate it is about sending a header, and drop the
initial hex count
* auto-censor Authorization headers by default
as suggested by Jeff King ($gmane/292074)
*Changes from V2
- fix garbage comment in http.c (i am very sorry for that)
- add final '.' to the commit message for imap-send.c and to other commit messages
- typofix double ; in http.c
- merge the nice cleanup and code refactoring of Ramsay Jones (Thank you very much !!)
- squash the previous commit 2/4
*Changes from V1
- introduced GIT_TRACE_CURL variable with its documentation
- changed the name of the temporary variable "i" in "w" in the helper routine
- used the c escape sequences instead of the hex equivalent
- dropped the previous GIT_DEBUG_CURL env var
- curl_dump and curl_trace factored out to a shared implementation
Elia Pinto (2):
http.c: implement the GIT_TRACE_CURL environment variable
imap-send.c: introduce the GIT_TRACE_CURL enviroment variable
[PATCH v7 1/2] http.c: implement the GIT_TRACE_CURL environment variable
Implement the GIT_TRACE_CURL environment variable to allow a
greater degree of detail of GIT_CURL_VERBOSE, in particular
the complete transport header and all the data payload exchanged.
It might be useful if a particular situation could require a more
thorough debugging analysis. Document the new GIT_TRACE_CURL
diff --git a/Documentation/git.txt b/Documentation/git.txt
index dd6dbf7..a46a356 100644
@@ -1077,6 +1077,14 @@ of clones and fetches.
cloning of shallow repositories.
See 'GIT_TRACE' for available trace output options.
+ Enables a curl full trace dump of all incoming and outgoing data,
+ including descriptive information, of the git transport protocol.
+ This is similar to doing curl --trace-ascii on the command line.
+ This option overrides setting the GIT_CURL_VERBOSE environment
+ See 'GIT_TRACE' for available trace output options.
Setting this variable to `1` will cause Git to treat all
pathspecs literally, rather than as glob patterns. For example,
diff --git a/http.c b/http.c
index df6dd01..d661408 100644
@@ -11,6 +11,7 @@