[PATCH] t9824: fix wrong reference value

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] t9824: fix wrong reference value

larsxschneider
0492eb4 fixed a broken &&-chain in this test which broke the test as it
checked for a wrong size. The expected size of the file under test is
39 bytes. The test checked that the size is 13 bytes. Fix the reference
value to make the test pass, again.

Signed-off-by: Lars Schneider <[hidden email]>
---
 t/t9824-git-p4-git-lfs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
index 64f8d18..3fc6790 100755
--- a/t/t9824-git-p4-git-lfs.sh
+++ b/t/t9824-git-p4-git-lfs.sh
@@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr
  # We only import HEAD here ("@all" is missing!)
  git p4 clone --destination="$git" //depot &&
 
- test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
+ test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
  test_file_count_in_dir ".git/lfs/objects" 1 &&
 
  cat >expect <<-\EOF &&

--
https://github.com/git/git/pull/235
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] t9824: fix wrong reference value

Junio C Hamano
Lars Schneider <[hidden email]> writes:

> 0492eb4 fixed a broken &&-chain in this test which broke the test as it
> checked for a wrong size. The expected size of the file under test is
> 39 bytes. The test checked that the size is 13 bytes. Fix the reference
> value to make the test pass, again.
>
> Signed-off-by: Lars Schneider <[hidden email]>
> ---

That breaking "fix" seems to have been acked by you.

It was sort of clear that SZEDER didn't actually ran the test from
the patch, saying "As far as I can tell after eyeballing the test
script,", but you obviously didn't actually have a chance to test it
until now.

Thanks for fixing it before it hits 'master'; this time I think it
is safe to assume that this was actually tested ;-)


>  t/t9824-git-p4-git-lfs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
> index 64f8d18..3fc6790 100755
> --- a/t/t9824-git-p4-git-lfs.sh
> +++ b/t/t9824-git-p4-git-lfs.sh
> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr
>   # We only import HEAD here ("@all" is missing!)
>   git p4 clone --destination="$git" //depot &&
>  
> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
> + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
>   test_file_count_in_dir ".git/lfs/objects" 1 &&
>  
>   cat >expect <<-\EOF &&
>
> --
> https://github.com/git/git/pull/235
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] t9824: fix wrong reference value

larsxschneider

On 29 Apr 2016, at 19:34, Junio C Hamano <[hidden email]> wrote:

> Lars Schneider <[hidden email]> writes:
>
>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it
>> checked for a wrong size. The expected size of the file under test is
>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference
>> value to make the test pass, again.
>>
>> Signed-off-by: Lars Schneider <[hidden email]>
>> ---
>
> That breaking "fix" seems to have been acked by you.
>
> It was sort of clear that SZEDER didn't actually ran the test from
> the patch, saying "As far as I can tell after eyeballing the test
> script,", but you obviously didn't actually have a chance to test it
> until now.
>
> Thanks for fixing it before it hits 'master'; this time I think it
> is safe to assume that this was actually tested ;-)

Yes! Lesson learned! Sorry Szeder!

- Lars


>
>
>> t/t9824-git-p4-git-lfs.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
>> index 64f8d18..3fc6790 100755
>> --- a/t/t9824-git-p4-git-lfs.sh
>> +++ b/t/t9824-git-p4-git-lfs.sh
>> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr
>> # We only import HEAD here ("@all" is missing!)
>> git p4 clone --destination="$git" //depot &&
>>
>> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
>> + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
>> test_file_count_in_dir ".git/lfs/objects" 1 &&
>>
>> cat >expect <<-\EOF &&
>>
>> --
>> https://github.com/git/git/pull/235

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] t9824: fix wrong reference value

Luke Diamand
On 29 April 2016 at 21:29, Lars Schneider <[hidden email]> wrote:

>
> On 29 Apr 2016, at 19:34, Junio C Hamano <[hidden email]> wrote:
>
>> Lars Schneider <[hidden email]> writes:
>>
>>> 0492eb4 fixed a broken &&-chain in this test which broke the test as it
>>> checked for a wrong size. The expected size of the file under test is
>>> 39 bytes. The test checked that the size is 13 bytes. Fix the reference
>>> value to make the test pass, again.
>>>
>>> Signed-off-by: Lars Schneider <[hidden email]>
>>> ---
>>
>> That breaking "fix" seems to have been acked by you.
>>
>> It was sort of clear that SZEDER didn't actually ran the test from
>> the patch, saying "As far as I can tell after eyeballing the test
>> script,", but you obviously didn't actually have a chance to test it
>> until now.
>>
>> Thanks for fixing it before it hits 'master'; this time I think it
>> is safe to assume that this was actually tested ;-)
>
> Yes! Lesson learned! Sorry Szeder!

How does the old saying go? If it hasn't been tested, it doesn't work!

Luke
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html