Could you justify your change with a bit more than "fix"? That is,
gitweb, when used with PATH_INFO, shows a link to parent diff
like [fill in the blank]. However, it is wrong because [fill in
Make it show it like [fill in the blank]. Because [fill in the
blank], delete 'hash_parent' element from the %params hash once
we used it; otherwise [fill in the blank to describe "this bad
As I understand it, it should instead directly point to the parent diff,
i.e. turn it into http://somedomain/somerepo.git/commitdiff/parenthash,
and delete 'hash_parent' element from the %params hash once we used it,
otherwise the '?hp=parenthash' string is appended.
Richard, at which view is this bad link present? Err... never mind, I see that
gitweb uses link to 'commitdiff' view with 'hash_parent' parameter set only
..in two places (well, perhaps there are some which get hash_parent from
-replay, but I doubt it): the "commit" view (link to each parent commit)
and in "commitdiff" view for octopus merges (e.g. "pu" in git.git).
The problem is not with ?hp=parenthash, but with /somehash part, which
somehow got invalid (from the error message). I have checked using
http://repo.or.cz/git.git, and while it has the bug (i.e. uses '?hp=...' instead
of path_info), there is no "400 - Invalid has parameter" error.
Just like href() does with hash_parent_base and hash_base for blobdiff.
Urgh... href() is a bit of mess, now I see it when I am not current.
>> and delete 'hash_parent' element from the %params hash once we used it,
>> otherwise the '?hp=parenthash' string is appended.
That's correct: the unstated rule of href is that if it went into path_info,
it is deleted (not everything can be expressed with path_info), the rest
goes into query parameters. So without deleting the element, it would
Note that using query parameter when we can use path_info is a minor
error; URL should work anyway (and I don't see why it doesn't - somewhat
the 'hash' parameter got incorrect...).
I'm sorry, I didn't notice it was meant for me. Simple "Jakub,..."
would be enough.
On Tue, May 24, 2016 at 8:39 PM, Junio C Hamano <[hidden email]> wrote:
> Richard Braun <[hidden email]> writes:
>> On Tue, May 24, 2016 at 11:17:28AM -0700, Junio C Hamano wrote:
>> Hum, see .
>> Tell me if I need to resend.
> Sorry, check the "To:" field of the message you are responding to.
> The ping was not meant to (and was not addressed to) you. It asked
> for comments from an area expert.
Only this made me realize that you are expecting *my* response.
Otherwise you would get correct link in your situation with
bad 'hash' parameter, but not the view that was requested;
it would not be diff between current and given parent, but
commitdiff for parent (to grandparent(s)).
Richard, thanks for finding a problematic thing, but you
need to search more for a true fix.