[PATCH] git-svn: add ability to specify --commit-url for dcommit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] git-svn: add ability to specify --commit-url for dcommit

Eric Wong
This allows one to use public svn:// URLs for fetch and
svn+ssh:// URLs for committing (without using the complicated
rewriteRoot option, reimporting or git-filter-branch).

Using this can also help avoid unnecessary server
authentication/encryption overhead on busy SVN servers.

Along with the new --revision option, this can also be allowed
to override the branch detection in dcommit, too.  This is
potentially dangerous and not recommended!  (And also purposely
undocumented, but the loaded gun is there in case somebody
wants to make it safe).

Signed-off-by: Eric Wong <[hidden email]>
---
 Documentation/git-svn.txt |    9 +++++++++
 git-svn.perl              |    9 ++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index 773ae96..1e644ca 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -138,6 +138,15 @@ and have no uncommitted changes.
 +
 --no-rebase;;
  After committing, do not rebase or reset.
+--commit-url <URL>;;
+ Commit to this SVN URL (the full path).  This is intended to
+ allow existing git-svn repositories created with one transport
+ method (e.g. `svn://` or `http://` for anonymous read) to be
+ reused if a user is later given access to an alternate transport
+ method (e.g. `svn+ssh://` or `https://`) for commit.
+
+ Using this option for any other purpose (don't ask)
+ is very strongly discouraged.
 --
 
 'log'::
diff --git a/git-svn.perl b/git-svn.perl
index df0ed90..06a82c8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -66,7 +66,7 @@ my ($_stdin, $_help, $_edit,
  $_version, $_fetch_all, $_no_rebase,
  $_merge, $_strategy, $_dry_run, $_local,
  $_prefix, $_no_checkout, $_url, $_verbose,
- $_git_format);
+ $_git_format, $_commit_url);
 $Git::SVN::_follow_parent = 1;
 my %remote_opts = ( 'username=s' => \$Git::SVN::Prompt::_username,
                     'config-dir=s' => \$Git::SVN::Ra::config_dir,
@@ -127,6 +127,8 @@ my %cmd = (
   'verbose|v' => \$_verbose,
   'dry-run|n' => \$_dry_run,
   'fetch-all|all' => \$_fetch_all,
+  'commit-url=s' => \$_commit_url,
+  'revision|r=i' => \$_revision,
   'no-rebase' => \$_no_rebase,
  %cmt_opts, %fc_opts } ],
  'set-tree' => [ \&cmd_set_tree,
@@ -416,6 +418,8 @@ sub cmd_dcommit {
  $head ||= 'HEAD';
  my @refs;
  my ($url, $rev, $uuid, $gs) = working_head_info($head, \@refs);
+ $url = $_commit_url if defined $_commit_url;
+ my $last_rev = $_revision if defined $_revision;
  if ($url) {
  print "Committing to $url ...\n";
  }
@@ -423,7 +427,6 @@ sub cmd_dcommit {
  die "Unable to determine upstream SVN information from ",
     "$head history.\nPerhaps the repository is empty.";
  }
- my $last_rev;
  my ($linear_refs, $parents) = linearize_history($gs, \@refs);
  if ($_no_rebase && scalar(@$linear_refs) > 1) {
  warn "Attempting to commit more than one change while ",
@@ -446,7 +449,7 @@ sub cmd_dcommit {
  my $cmt_rev;
  my %ed_opts = ( r => $last_rev,
                 log => get_commit_entry($d)->{log},
-                ra => Git::SVN::Ra->new($gs->full_url),
+                ra => Git::SVN::Ra->new($url),
                 config => SVN::Core::config_get_config(
                         $Git::SVN::Ra::config_dir
                 ),
--
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html