[PATCH] attr: explain the lack of attr-name syntax check in parse_attr()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] attr: explain the lack of attr-name syntax check in parse_attr()

Junio C Hamano

Signed-off-by: Junio C Hamano <[hidden email]>
---
 attr.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/attr.c b/attr.c
index 94b27f4..aac5c8f 100644
--- a/attr.c
+++ b/attr.c
@@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp,
  return NULL;
  }
  } else {
+ /*
+ * As this function is always called twice, once with
+ * e == NULL in the first pass and then e != NULL in
+ * the second pass, no need for invalid_attr_name()
+ * check here.
+ */
  if (*cp == '-' || *cp == '!') {
  e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET;
  cp++;
--
2.8.2-748-gfb85f76

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html